Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapped Product Clicked to select_item #23

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

vlee90
Copy link
Contributor

@vlee90 vlee90 commented Dec 14, 2023

select_item contains the items event property (docs). select_content does not contain items (docs)

This is significant because the other GA4/Firebase ecommerce events such as:

  • view_item_list (docs)
  • view_item (docs)
  • purchase (docs)
  • etc

All contain the items property.

A fairly standard ecommerce flow is:

  1. View Product List (view_item_list)
  2. Select Product from List (could be select_item, but is currently select_content)
  3. View Product Detail Page (view_item)
  4. Add to Cart (add_to_cart)
  5. Checkout Steps (begin_checkout)
  6. Purchase (purchase)

All of the above steps are replicated with Firebase/GA4 events. All of those events, except for select_content have items, which map to the products array for the Segment implementation. select_content breaks a pattern and is preventing our products from appearing in Firebase/GA4 when our Segment Product Clicked event is fired.

We are proposing that Product Clicked gets mapped to select_item instead of select_content.

Docs:

cc: @jordantannenbaum1

@bsneed bsneed merged commit a58c8fe into segment-integrations:main Dec 14, 2023
2 checks passed
@bsneed
Copy link
Contributor

bsneed commented Dec 14, 2023

Thanks @vlee90 ! I'll make a release shortly. Nice find, thank you for that!

@bsneed
Copy link
Contributor

bsneed commented Dec 14, 2023

Done. See 1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants